[WIP] Address feedback on coefficient consistency for HDF5 files#195
Merged
The9Cat merged 4 commits intocoefExtendCheckfrom Dec 13, 2025
Merged
[WIP] Address feedback on coefficient consistency for HDF5 files#195The9Cat merged 4 commits intocoefExtendCheckfrom
The9Cat merged 4 commits intocoefExtendCheckfrom
Conversation
Co-authored-by: The9Cat <25960766+The9Cat@users.noreply.github.com>
The9Cat
approved these changes
Dec 13, 2025
Co-authored-by: The9Cat <25960766+The9Cat@users.noreply.github.com>
Co-authored-by: The9Cat <25960766+The9Cat@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CheckH5Paramsimplementations for emptycoefsaccessTableData::CheckH5Params(line 2776) - addresses feedbackCheckH5Paramsmethods for consistency:SphCoefs::CheckH5ParamsCylCoefs::CheckH5ParamsSlabCoefs::CheckH5ParamsCubeCoefs::CheckH5ParamsSphFldCoefs::CheckH5ParamsCylFldCoefs::CheckH5ParamsSummary
Added defensive checks to prevent undefined behavior when accessing
coefs.begin()->secondin allCheckH5Paramsmethods. If thecoefsmap is empty, the methods now return false and log an appropriate error message instead of crashing.💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.